Crystal and ci updates (#1862)

* Update CI and min Crystal version required to 1.10 * fixing new deprecation warnings
luckyframework · Apr 10, 2024 · b5dfa0a · b5dfa0a
1 parent 3c5c296
commit b5dfa0a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,7 +15,7 @@ jobs:
     env:
       SKIP_LUCKY_TASK_PRECOMPILATION: "1"
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v4
       - uses: crystal-lang/install-crystal@v1
         with:
           crystal: latest
@@ -32,7 +32,7 @@ jobs:
         shard_file:
           - shard.yml
         crystal_version:
-          - 1.9.0
+          - 1.10.0
           - latest
         experimental:
           - false
@@ -48,7 +48,7 @@ jobs:
     env:
       SKIP_LUCKY_TASK_PRECOMPILATION: "1"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: crystal-lang/install-crystal@v1
         with:
           crystal: ${{matrix.crystal_version}}

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -8,7 +8,7 @@ jobs:
   deploy:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           persist-credentials: false
       - uses: crystal-lang/install-crystal@v1
@@ -19,7 +19,7 @@ jobs:
       - name: "Generate docs"
         run: crystal docs
       - name: Deploy to GitHub Pages
-        uses: peaceiris/actions-gh-pages@v3
+        uses: peaceiris/actions-gh-pages@v4
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           publish_dir: ./docs
diff --git a/shard.yml b/shard.yml
@@ -1,7 +1,7 @@
 name: lucky
 version: 1.1.0
 
-crystal: ">=1.9.0"
+crystal: ">= 1.10.0"
 
 authors:
   - Paul Smith <paulcsmith0218@gmail.com>

diff --git a/src/lucky/renderable.cr b/src/lucky/renderable.cr
@@ -88,11 +88,11 @@ module Lucky::Renderable
   # enum for more available http status codes.
   macro html_with_status(page_class, status, **assigns)
     {% if status.is_a?(SymbolLiteral) %}
-      html {{ page_class }}, _with_status_code: HTTP::Status::{{ status.upcase.id }}.value, {{ **assigns }}
+      html {{ page_class }}, _with_status_code: HTTP::Status::{{ status.upcase.id }}.value, {{ assigns.double_splat }}
     {% elsif status.is_a?(Path) && status.names.join("::").starts_with?("HTTP::Status::") %}
-      html {{ page_class }}, _with_status_code: {{ status.resolve }}, {{ **assigns }}
+      html {{ page_class }}, _with_status_code: {{ status.resolve }}, {{ assigns.double_splat }}
     {% else %}
-      html {{ page_class }}, _with_status_code: {{ status }}, {{ **assigns }}
+      html {{ page_class }}, _with_status_code: {{ status }}, {{ assigns.double_splat }}
     {% end %}
   end