LDEV-4745 address issue where classes are not fetched from class loader when they already exist #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er when they already exist This appears to arise when the PageSource for a page is flushed/cleared but when the class still exists in the class loader and using the latest version of the source. Fix works by checking whether we already have a compiled binary class file that is newer than source file and attempting to fetch the class from the class loader.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to arise when the PageSource for a page is flushed/cleared but when the class still exists in the class loader and using the latest version of the source.
Fix works by checking whether we already have a compiled binary class file that is newer than source file and attempting to fetch the class from the class loader.
Would be good to get a simple test case for this to add to the test suite. I was able to reproduce this in Lucee 5.4 with a Preside application with a lot of loaded classes. Page source appeared to be cleared in high memory usage scenarios. This change (slightly different in 5.4) resolved completely.