Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: CallbackOnCollectedDelegate exception occurred. #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stjeong
Copy link

@stjeong stjeong commented Nov 26, 2018

Passing delegate instance into native function directly can produce CallbackOnCollectedDelegate after GC.

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   65.68%   65.68%           
=======================================
  Files         215      215           
  Lines       38993    38993           
  Branches     4091     4091           
=======================================
  Hits        25613    25613           
  Misses      13118    13118           
  Partials      262      262
Flag Coverage Δ
#WGL_net35_x64_Release 92.25% <ø> (ø) ⬆️
#WGL_net35_x86_Release 91% <ø> (ø) ⬆️
#WGL_net461_x64_Release 65.26% <ø> (ø) ⬆️
#WGL_net461_x86_Release 90.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e10f2...58e501d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant