Enable platform specific raw flags for compile and link steps with 'cflags' and 'lflags'.

[gaspard]

Hi there !

This fixes issues #367 and #129.

It is a clean change that does not break compatibility with previous luarocks versions.

This change would allow releasing libraries such as lui (minimal ui library) and lens (scheduler) as these require Mac OS X frameworks. I have some other installation issues for Windows that could be solved by using platform specific flags.

Cheers !

Gaspard

[hishamhm]

Hi!

It is a clean change that does not break compatibility with previous luarocks versions.

Unfortunately it does break compatibility because it extends the grammar of the rockspec format. In other words, rockspecs using this feature will not work on older LuaRocks releases.

I've been meaning to create the luarocks-3 branch for a while now (in which features like this will be welcome). I won't be able to do it this week as I'm focusing on other work right now, but my plan is to do it later this month (preferrably before the start of the Google Summer of Code coding phase, so that the student works his branch off the new "hot" codebase).

[hishamhm]

(Never mind the Travis CI failure. It was for an unrelated reason)

I'll keep this on hold until we get the new branch. Thanks for submitting!

[gaspard]

Hmmm... I am not sure it "breaks compatibility" because if these flags are
not present (as in previous versions), they are simply ignored.

Or do you mean people submitting build tables that contain keys not in the
current spec ? In this case, yes, weird things could happen but it seems
very far fetched.

But maybe, you simply mean that it changes the semantics and therefore
needs a new version number (as in http://semver.org/).

Cheers and thanks for responding so fast :-)

Gaspard

Gaspard Bucher
teti sàrl

On Mon, May 11, 2015 at 4:26 PM, Hisham Muhammad notifications@github.com
wrote:

(Never mind the Travis CI failure. It was for an unrelated reason)

I'll keep this on hold until we get the new branch. Thanks for submitting!

—
Reply to this email directly or view it on GitHub
#368 (comment)
.