cmd: 'server' option change #1563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed 'server' option, so it now can take several URLs. e.g '--server 'URL1 URL2 URL3'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1563 +/- ##
=======================================
Coverage 79.16% 79.17%
=======================================
Files 89 89
Lines 11154 11158 +4
=======================================
+ Hits 8830 8834 +4
Misses 2324 2324 ☔ View full report in Codecov by Sentry. |
hishamhm
reviewed
Jan 25, 2024
| @@ -455,9 +459,10 @@ Enabling completion for Fish: | |||
| end) | |||
| parser:flag("--dev", "Enable the sub-repositories in rocks servers for ".. | |||
| "rockspecs of in-development versions.") | |||
| parser:option("--server", "Fetch rocks/rockspecs from this server ".. | |||
| parser:option("--server", "Fetch rocks/rockspecs from this servers ".. | |||
There was a problem hiding this comment.
I think there is an method in argparse to allow an option to be passed multiple times (resulting in an array of values). I think that would be preferrable to relying on splitting by spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed 'server' option, so it now can take several URLs.
e.g '--server 'URL1 URL2 URL3''.