Platform version overrides #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform strings used in override tables or the supported_platform list is a dependency string. The deps.match_platform function will compare this string to the detected platform and system name. The old cfg.is_platform function matches only plain strings against built-in platform names (like it always has).
|
This looks good, but creates an incompatibility in the rockspec format. But it definitely sounds like something to be added in the next major version of LuaRocks. So let's keep this patch on hold for a while and add it later. |
Conflicts: Makefile src/luarocks/deps.lua src/luarocks/util.lua
hishamhm
force-pushed
the
master
branch
2 times, most recently
from
e237af3
to
0477604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform names can include version information. The platform string is treated as a dependency string.
Internally, LuaRocks maintains a list of generic platform types, and an additional canonical name for the current system. The function
luarocks.cfg.is_platformwill compare a string with the generic types regardless of system version. The functionluarocks.deps.match_platformcompares a string to the generic and canonical names with version numbers.The version of a system is determined with
uname -ron Unix-like platforms, andVERon Windows. It is set as the variableLUAROCKS_UNAME_Rin the site config upon installation.TODO: Possible use an external program to read the WIndows version because
VERmay not be reliable. The Windows build should set a variable WINVER that can be optionally used by rockspecs to set a compiler macro.