WIP: Detect and config for SerenityOS #1445
Conversation
Codecov ReportBase: 79.03% // Head: 78.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1445 +/- ##
==========================================
- Coverage 79.03% 78.33% -0.71%
==========================================
Files 89 89
Lines 11054 10759 -295
==========================================
- Hits 8737 8428 -309
- Misses 2317 2331 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -192,6 +192,11 @@ local function detect_elf_system(fd, hdr, sections) | |||
| return "linux" | |||
| end | |||
| end | |||
|
|
|||
| local uname_s = io.popen("uname -s"):read("*l") | |||
There was a problem hiding this comment.
The goal of the sysdetect module is to implement OS and architecture detection without forking processes. There should be a way to detect the OS and architecture uniquely by verifying some fixed location in the filesystem or the identifying headers of well-known executables.
|
@dlemos Thank you for the initiative! I gave the PR a first look and left you a review comment. |
SerenityOS is a Unix-like operating system built from scratch. LuaRocks build and run on the build directory but I still can't get it to run after installing it.