SSH key validation #108
Open
SSH key validation #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, I will look at it. |
|
Just pushed an update, because somehow I forgot functions.inc.php :/ |
plewin
requested changes
Jul 5, 2017
| echo "<div class=\"help alert alert-warning\">\n"; | ||
| echo "<p>".$messages["sshkeypolicy"]."</p>\n"; | ||
| echo "<ul>\n"; | ||
| if ( $sshkey_min_bits ) { echo "<li>".$messages["sshkeypolicyminbits"] ." $sshkey_min_bits</li>\n"; } |
There was a problem hiding this comment.
There are uneeded extra spaces here.
| @@ -239,6 +260,29 @@ function check_password_strength( $password, $oldpassword, $pwd_policy_config, $ | |||
| return $result; | |||
| } | |||
|
|
|||
| function check_sshkey( $ssh_pubkey, $sshkey_policy_config ) { | |||
There was a problem hiding this comment.
This function needs unit testing with different keys and policies.
| $parts = explode(' ', $ssh_pubkey); | ||
|
|
||
| # Check this gave us at least two parts, and SSH key type is valid | ||
| if (count($parts) < 2 || $parts[0] != 'ssh-rsa') { return "keyinvalid"; } |
There was a problem hiding this comment.
The function considers all non rsa keys as invalid. I do not think it is acceptable to disallow other types of keys : dsa, ecdsa and ed25519.
|
Completely forgot about this, I'll look into it soon. :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the SSH Key page to support key bit size checking, as well as some updates for better wording.
I have not yet done the additional languages. I can do that in a separate pull request if desired, though be warned it will be through Google Translate. ;)
Edit: Looks like I have to do translations. @_@ Ok, one moment...