Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stack overflow for large projects #1484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix stack overflow for large projects #1484

wants to merge 1 commit into from

Commits on Jul 26, 2023

  1. Fix stack overflow for large projects 

    When large projects have a lot of missing objects in the first pass of parsing Ruby files we would run into stack overflows. This happens because, when there was a missing object in a parsed Ruby file, we would recursively call `#parse_remaining_files`. When this happens a lot the stack would get huge.

We fix this by instead keeping a list of files that we want to retry and re-parse them in another pass. When we can no longer resolve any more files we break the loop.
    Andrew Szczepanski authored and Andrew Szczepanski committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8a14e13 View commit details
    Browse the repository at this point in the history