Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increasing code coverage issue #46 #862

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

michabs
Copy link

@michabs michabs commented Jun 25, 2023


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@muniu-bot
Copy link

muniu-bot bot commented Jun 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michabs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zwpaper
Copy link
Member

zwpaper commented Jul 13, 2023

hi @michabs, thanks for contributing, your code seems not to pass the test, you can test locally by

cargo test

@michabs
Copy link
Author

michabs commented Jul 13, 2023 via email

@zwpaper
Copy link
Member

zwpaper commented Jul 28, 2023

hi @michabs, sorry for the late reply, please feel free to ask any questions.

you can refer to https://github.com/lsd-rs/lsd/blob/master/src/color.rs#L204C12-L204C20 and use it like

colors.colorize(target_string, elem),
,

or refer to https://github.com/lsd-rs/lsd/blob/8acaabec723cdd71b498212c8a47ac952d022738/src/meta/symlink.rs#L59C2-L59C2 to create a ColoredString directly.

please let me know if I misunderstood your question or if it did not help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants