Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use private CSI sequence for marking #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srlehn
Copy link

@srlehn srlehn commented Nov 14, 2023

πŸš€ Changes proposed by this PR

πŸ”— Related bug reports/feature requests

ISSUE: The ANSI CSI sequence used for marking should be a private one #19

🧰 Type of change

  • [βœ” ] Bug fix (non-breaking change which fixes an issue).

Use private CSI sequence instead of the already defined CBT CSI sequence.

Fixes #19

πŸ“ Notes to reviewer

https://en.wikipedia.org/wiki/ANSI_escape_code#CSI_(Control_Sequence_Introducer)_sequences

"A subset of arrangements was declared "private" so that terminal manufacturers could insert their own sequences without conflicting with the standard. Sequences containing the parameter bytes <=>? or the final bytes 0x70–0x7E (p–z{|}~) are private. "


https://www.ecma-international.org/wp-content/uploads/ECMA-48_5th_edition_june_1991.pdf

5.4.d) F is the Final Byte; it consists of a bit combination from 04/00 to 07/14; it terminates the control sequence and together with the Intermediate Bytes, if present, identifies the control function.

Bit combinations 07/00 to 07/14 are available as Final Bytes of control sequences for private (or experimental) use.

5.4 Table 3: ("Z" = column 05, row 10 -> "CBT")


https://vt100.net/docs/vt510-rm/chapter4.html (search for "CBT)

🀝 Requirements

  • [βœ” ] ✍ I have read and agree to this projects Code of Conduct.
  • [βœ” ] ✍ I have read and agree to this projects Contribution Guidelines.
  • [βœ” ] ✍ I have read and agree to the Developer Certificate of Origin.
  • [ βœ”] πŸ”Ž I have performed a self-review of my own changes.
  • [ βœ”] 🎨 My changes follow the style guidelines of this project.
  • πŸ’¬ My changes as properly commented, primarily for hard-to-understand areas.
  • πŸ“ I have made corresponding changes to the documentation.
  • πŸ§ͺ I have included tests (if necessary) for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: bubblezone filters out CBT CSI sequences
1 participant