Android Test Suites #2039
Draft
Android Test Suites #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slime73
reviewed
Mar 16, 2024
In Android, the tests are running in fused mode. This means the source directory is not writeable.
Needed for Android.
The tests uses `getSource()` which is not supported when the test program run inside .love file or when fused.
In particular: * `love.window.getMode()` width and height always return the fullscreen dimensions. * Maximization function is undefined/unavailable. * Minimizing in mobile causes the test suites to be paused.
love.window.restore causes the app to be minimized in Android, pausing the execution. Note that this may actually work in multi-window scenario but for now skip them.
MikuAuahDark
force-pushed
the
test-android
branch
from
d60ebf6
to
5442419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suites assume certain environment condition which can't be satisfied in Android. In particular:
love.filesystem.getSource()does not point to writeable directory. This is true if the test suite program is packaged as .love file or when fused. This is the case for Android test suite (in the future).love.filesystem.getSource()quirks, then themountFullPathandunmountFullPathtests are skipped entirely.love.window.getMode()always return near-fullscreen dimensions. In this case, skip the width/height checks.love.window.restore()pauses the program execution for some reason, so tests calling this function will be skipped (including itself).Marking it as draft as I haven't wrote the actual automated Android testing using AVD yet.