Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to delete board if the last user left #201

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

DanielHabenicht
Copy link
Contributor

When DELETE_ON_LEAVE is set to true (default is false) the board will be automatically deleted as the last user leaves.

Before leaving the user will be asked if he is sure to leave (I would wait for #195 to not ask if the board was saved before).

The default behavior is not changed.

resolves #199

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

@DanielHabenicht DanielHabenicht marked this pull request as draft June 2, 2021 15:49
@DanielHabenicht DanielHabenicht marked this pull request as ready for review June 2, 2021 22:47
@DanielHabenicht
Copy link
Contributor Author

If you have problems with formatting I can recommend: https://restyled.io/

Copy link

@Forest-Dewberry Forest-Dewberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good feature addition

@DanielHabenicht
Copy link
Contributor Author

If you want the conflicts resolved just hit me up with when you are ready to review. @PackageAuthor

@DanielHabenicht
Copy link
Contributor Author

DanielHabenicht commented Mar 22, 2022

  • Fix behaviour for newly joined users.
  • Do not display the dialog for iframe integrated instances

* within iframe (embedded) no "save me" popup will be displayed
* if a newly joined user is the last user the "save me" popup will also be displayed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Board as the last user leaves
2 participants