Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Board as the last user leaves #199

Open
DanielHabenicht opened this issue Jun 2, 2021 · 6 comments · May be fixed by #201
Open

Delete Board as the last user leaves #199

DanielHabenicht opened this issue Jun 2, 2021 · 6 comments · May be fixed by #201

Comments

@DanielHabenicht
Copy link
Contributor

For ad-hoc privacy conscious users it would be great if the board can be deleted as the last user leaves.

Maybe with a popup for the last user weather he want to save it before.

Should I also add an option to make configurable via environment variables?
@elearningdienst
Copy link

Thats a great idea. In my opinion the Popup should be just shown for the user who initionally opens the board.

DanielHabenicht added a commit to DanielHabenicht/whitebophir that referenced this issue Jun 2, 2021
@DanielHabenicht
add option to delete board if the last user left
93608f2 
resolves Delete Board as the last user leaves lovasoa#199
@DanielHabenicht DanielHabenicht linked a pull request Jun 2, 2021 that will close this issue
Open
@chr5tphr
Copy link

chr5tphr commented Jun 7, 2021 •
edited

Maybe instead there could be 2 types of boards: "volatile" boards that are always deleted after the last user leaves, and "persistent" boards that are preserved, like current boards. This way, a running instance could give both options to users when creating a board, without the need of a popup. But I guess a per-board configuration would probably be better...

@DanielHabenicht
Copy link
Contributor Author

It think that my be a good idea to have it completely separated.
Furthermore we should add a banner to the top that this board is volatile.

@lovasoa what do you think?

@SushantGautam
Copy link

It think that my be a good idea to have it completely separated.
Furthermore we should add a banner to the top that this board is volatile.

@lovasoa what do you think?

For simple implementations, we can have URL params for such. Like "IsVolatile"
Drawing with such params configs are not stored in a server just transmitted while in Socket connection.

@DanielHabenicht
Copy link
Contributor Author

@SushantGautam I think that's a different idea. Somebody joining to an already drawn whiteboard would have an incomplete view.

@DanielHabenicht DanielHabenicht mentioned this issue Mar 30, 2022
Open
@DanielHabenicht
Copy link
Contributor Author

As for our use we have an external system using the whiteboard (nameley jitsi) and the "delete board as last user leaves" functionality won't be triggered for embedded iframes. So we implemented an admin api for deleting the board.

If @lovasoa decides on how to go about this feature I am happy to modify #201 (e.g. implementing a volatile flag).
I added a PR for the admin API here: #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add option to delete board if the last user left DanielHabenicht/whitebophir
4 participants
@DanielHabenicht @chr5tphr @SushantGautam @elearningdienst