Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs to a httpbingo on example requests and adding webrick for ruby 3.x support #1383

Merged
merged 3 commits into from Jan 18, 2022
Merged

update docs to a httpbingo on example requests and adding webrick for ruby 3.x support #1383

merged 3 commits into from Jan 18, 2022

Conversation

JAugusto42
Copy link
Contributor

Description

olleolleolle
olleolleolle approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @JAugusto42! This is very helpful 👍.

@olleolleolle
Copy link
Member

The complaints from Rubocop can be autofixed using the rubocop -A option. Please do that and push the changes, when you get a chance. No rush.

@JAugusto42
Copy link
Contributor Author

yeah, i'm sorry.

@olleolleolle
Copy link
Member

@JAugusto42 thanks for helping out, it's awesome!

iMacTia
iMacTia approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@iMacTia iMacTia merged commit 9f80f87 into lostisland:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JAugusto42 @olleolleolle @iMacTia