Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log_level option to logger default formatter #1079

Merged
merged 4 commits into from
Dec 27, 2019

Conversation

amrrbakry
Copy link
Contributor

@amrrbakry amrrbakry commented Nov 22, 2019

Description

Logger default formatter log severity can now be configured through the log_level option (related #1078)

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Documentation

Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature addition, latest Rubocop issues have been fixed in master and should now be green

@iMacTia iMacTia merged commit 9726bc2 into lostisland:master Dec 27, 2019
@amrrbakry amrrbakry deleted the default_formatter_log_level branch December 27, 2019 17:20
@amrrbakry
Copy link
Contributor Author

awesome! thank you 👍

dgholz added a commit to dgholz/oauth2 that referenced this pull request Jan 24, 2020
lostisland/faraday#1079 changed the logging to all use
the same level, and it defaults to `:info`. This changed the log level used for
request and response headers and bodies.  I changed the specs to expect the
logs from Faraday to be INFO-level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants