Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add move_forwards(dist) for Actor. Closes #193 #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add move_forwards(dist) for Actor. Closes #193 #194

wants to merge 1 commit into from

Conversation

nbogie
Copy link

@nbogie nbogie commented Aug 7, 2019

Adds the ability to say myActor.move_forwards(10).

Hi! I hope you don't mind me making a PR without first discussing the feature request. No worries at all if you just close this, but I'd certainly be interested in your thinking on what pygamezero actors should and should not directly provide.

@lordmauve
Copy link
Owner

This is pretty good.

The problem is that Actors don't have a "forwards" exactly. In the docs we talk about a ship sprite facing right in order to use angle_to() to aim. But that's only a convention. If you have a sprite that faces upwards, you can still rotate it by increasing and decreasing angle.

I would be happy to accept this if you can add docs stating what exactly forwards means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants