Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bounding box class to store dimensions and anchor. #185

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

martindemello
Copy link
Contributor

Reworks a bunch of property update code in Actor to use a bounding box.

This is a refactoring en route to supporting more transformations (flipping, scaling).

Rework a bunch of property update code in Actor to use a bounding box.
@martindemello
Copy link
Contributor Author

Fixes #3, addresses #36 via a slightly different API

@lordmauve
Copy link
Owner

I'm so sorry, I must have missed this PR! (GitHub emails were going into my spam folder for a time). I will pull it and review when I get a chance.

@martindemello
Copy link
Contributor Author

no worries, i figured life just got busy for you :)

@martindemello
Copy link
Contributor Author

ping? i still feel like this would make doing several other things easier (e.g. #193 and #213)

@martindemello
Copy link
Contributor Author

One last try at getting this merged - it would let me send in fixes for several other issues (#193, #131, #36 and #3) pretty quickly, and I'd be happy to rework it to fix any issues you have with the code, or if it conflicts with some other ideas you have for pgzero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants