Improve nmap #26
Open
Improve nmap #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add networks path netbox-scanner.py: Add dir_config option Read networks file networks.txt: Move to expected location and added some examples nmap.py: Use of nmap library to simplify nmap scan requirements.txt: Update requirements.txt with nmap library and update other libraries to latest compatible version
|
Pending to check compatibility with new way of dealing with tags (not related to the change but related with functionality in new netbox) |
… wasn't working, don't know if it was dependant on old Netbox version) nmap.py: Add extra function to improve DNS resolution since nmap is not always consistent
…force always DNS resolution)
|
Will this be accepted? Looks nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great job you're being doing 👍
I've modified a bit the code to use python 3 nmap library. I've been using it and I thought that maybe other people could use this.
I'm planning to work a bit more on the code in the future :)
Since I couldn't find a Contributors file (or how to contribute) I hope this is fine