Skip to content

Commit 15cd763

Browse files
author
Doug Davis
authored
chore: minor typos in guidance docs (cloudevents#196)
Signed-off-by: Doug Davis <dug@us.ibm.com>
1 parent aa320e7 commit 15cd763

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

maintainer_guidelines.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ Here are a few tips for repository maintainers.
77
* Stay on top of your pull requests. PRs that languish for too long can become difficult to merge.
88
* Work from your own fork. As you are making contributions to the project, you should be working from your own fork just as outside contributors do. This keeps the branches in github to a minimum and reduces unnecessary CI runs.
99
* Try to proactively label issues and pull requests with labels
10-
* Actively review pull requests as the are submitted
10+
* Actively review pull requests as they are submitted
1111
* Triage issues once in a while in order to keep the repository alive.
1212
* If some issues are stale for too long because they are no longer valid/relevant or because the discussion reached no significant action items to perform, close them and invite the users to reopen if they need it.
13-
* If some PRs are no longer valid due to conflicts, but the PR is still needed, ask the contributor to rebase their PR
14-
* If some issues and PRs are still relevant, use labels to help organize tasks
13+
* If some PRs are no longer valid due to conflicts, but the PR is still needed, ask the contributor to rebase their PR.
14+
* If some issues and PRs are still relevant, use labels to help organize tasks.
1515
* If you find an issue that you want to create a pull request for, be sure to assign it to yourself so that other maintainers don't start working on it at the same time.
1616

1717
## Landing Pull Requests
@@ -26,7 +26,7 @@ When landing pull requests, be sure to check the first line uses an appropriate
2626

2727
## Branch Management
2828

29-
The `master` branch is is the bleeding edge. New major versions of the module
29+
The `master` branch is the bleeding edge. New major versions of the module
3030
are cut from this branch and tagged. If you intend to submit a pull request
3131
you should use `master HEAD` as your starting point.
3232

pr_guidelines.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ you might create a branch named `48-fix-http-agent-error`.
3636
```console
3737
git fetch upstream
3838
git reset --hard upstream/master
39+
git checkout FETCH_HEAD
3940
git checkout -b 48-fix-http-agent-error
4041
```
4142

@@ -82,7 +83,7 @@ Use your real name (sorry, no pseudonyms or anonymous contributions.)
8283

8384
The sign-off is a signature line at the end of your commit message. Your
8485
signature certifies that you wrote the patch or otherwise have the right to pass
85-
it on as open-source code. See [developercertificate.org](http://developercertificate.org/))
86+
it on as open-source code. See [developercertificate.org](http://developercertificate.org/)
8687
for the full text of the certification.
8788

8889
Be sure to have your `user.name` and `user.email` set in your git config.

0 commit comments

Comments
 (0)