Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for user key using json has instead of an explicit read and check #1642

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

apatruni
Copy link

Short description

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

Copy link
Member

@sudheesh001 sudheesh001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. However I'd suggest a few changes before this can be merged.

Would it be possible to change the commit message to:
Checks for user key using json has instead of an explicit read and check

With the change in commit message, I think this can be approved.

Handing over the second review to @Orbiter

@apatruni apatruni changed the title check for field Checks for user key using json has instead of an explicit read and check Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants