Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TwitterScraperTest #1633

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix TwitterScraperTest #1633

wants to merge 2 commits into from

Conversation

ullf
Copy link

@ullf ullf commented Oct 5, 2018

To fix an error:
org.loklak.harvester.TwitterScraperTest > testSimpleSearch FAILED
java.time.format.DateTimeParseException at TwitterScraperTest.java:198

org.loklak.TestRunner > org.loklak.harvester.TwitterScraperTest.testSimpleSearch FAILED
java.time.format.DateTimeParseException at TwitterScraperTest.java:198

@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #1633 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             development   #1633   +/-   ##
=============================================
  Coverage           9.73%   9.73%           
  Complexity           459     459           
=============================================
  Files                211     211           
  Lines              19427   19427           
  Branches            3578    3578           
=============================================
  Hits                1891    1891           
  Misses             17194   17194           
  Partials             342     342

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01474bc...4e0469f. Read the comment docs.

Copy link
Member

@vibhcool vibhcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you tag the issue no. with the PR? changes look good to me, but the issue isn't clear

@vibhcool
Copy link
Member

related issue -> #1632
you may set PR heading like this one -> https://github.com/loklak/loklak_server/pull/1557/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants