Fix bug in csvToJson method. #94
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 62.99% 62.99%
=======================================
Files 1 1
Lines 254 254
=======================================
Hits 160 160
Misses 94 94
Continue to review full report at Codecov.
|
| @@ -84,7 +84,7 @@ def csvToJson(self, csvData = None, fieldnamesList = None): | |||
| if csvData: | |||
| data = csv.DictReader( csvData, fieldnames = fieldnamesList) | |||
| jsonData = json.dumps( [ row for row in data ] ) | |||
| return out | |||
| return jsonData | |||
There was a problem hiding this comment.
if the code doesn't enter the csvData if block, it ends up returning '' which is not a valid json. if the JSON is what needs to be returned then ideally it should return {}
There was a problem hiding this comment.
Then that should be applied to xmlToJson method too.
This method not at all gives expected output json. Should I change the whole definition of this method?(which can generate right json data from csv)
There was a problem hiding this comment.
Absolutely! Thanks for catching that. Feel free to make a change to that too. 😄
Fixes #93