Enhance (dev): Resource handling and update pdf and syntax highlighter libraries #9926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
:type/enhancement
sprocketc
changed the title
sprocketc
requested review from
andelf,
xyhp915,
logseq-cldwalker and
tiensonqin
andelf
approved these changes
Aug 3, 2023
logseq-cldwalker
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
@sprocketc Thanks for the excellent work in making our app more secure and maintainable! 👍 ❤️ I QAed the all the libraries on mac except for lightning-fs (which it seems @andelf introduced) and couldn't find any issues. From my test pdf it seems this resolves #9725.
| @@ -72,7 +72,8 @@ | |||
| "ios:dev": "cross-env PLATFORM=ios gulp cap", | |||
| "android:dev": "cross-env PLATFORM=android gulp cap", | |||
| "tldraw:build": "yarn --cwd tldraw install", | |||
| "postinstall": "yarn tldraw:build" | |||
| "amplify:build": "yarn --cwd packages/amplify install", | |||
| "postinstall": "yarn tldraw:build && yarn amplify:build " | |||
tiensonqin
force-pushed
the
enhance/resource-handling
branch
from
2acbf56
to
a28ae05
Compare
This was referenced Aug 4, 2023
|
@logseq-cldwalker Thanks for the reminder, I'll check lightning-fs. |
logseq-cldwalker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on #9907 and #9761
v5.1.2, so I had to usemarked.parseinstead ofmarked(see breaking changes of v4). To test this open our plugins modal and click on plugin from the marketplace to view its readme. Also, install a plugin and navigate to Settings -> Plugins.10.4.1, but we didn't seem to use this package in any way. The bundled js file was atv9.18.1. I used the former (latest is11.8.0). Create a code highlighted block on a whiteboard portal to test this. We fallback to hljs in portals and slides.0.0.2.3is the only clue and doesn't make sense (see the related commit).magic-portal- 8146430 Update: Reverted because some e2e tests were failing on CI. I assume the problem is this. The bundled file usesdeleteinstead ofclear, and that seems to be the only difference between the packages. Any ideas? Forking or installing from a commit isn't great, but it might be better than bumping into this again in the future (it took me a while to figure out the problem).I used the exact same version, so our PDF viewer should work as expected.Update: 2acbf56 I upgraded the package to fix various upstream issues @xyhp915 The internal property
textLayerDivseems to be renamed todiv.Resolves PDF math equations are displayed incorrectly #8316
I reproduced this and confirmed that it's fixed, I couldn't reproduce the rest of the issues, but we should check the following when this is released
resources/css/tooltip.csswere a modified version ofreact-tippy/dist/tippy.css. The introducedsrc/main/frontend/tippy-tooltip.cssis their diff with some code style modifications. We now import the original tippy styles and override those rules if needed. Tooltips should look the way they used to on both theme modes.tailwind.all.cssI think we can move those files closer to the corresponding cljs sources. Made some formatting improvements removed vendor-prefixed properties.