Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace defaultLenisOptions object with function #534

Open
wants to merge 1 commit into
base: v5-beta
Choose a base branch
from

Conversation

somespecialone
Copy link

Fixes #507.
Guys, thanks for your work! Just really want to fix the problem in Node environment for using SSR/SSG with this lib (I make my own wrapper for Vue/Nuxt).

@devenini devenini added the v5 label Dec 3, 2023
@tekigg
Copy link

tekigg commented Dec 4, 2023

How'd you go about implementing this in something like nuxt? :0

@somespecialone
Copy link
Author

somespecialone commented Dec 4, 2023

How'd you go about implementing this in something like nuxt? :0

All actions can and will be ClientOnly, of course. Just don't want to import lib dynamically on client in separate chunk, but can't even import it and build with due to window and document on top of the file

@somespecialone
Copy link
Author

@tekigg , after all I ended up with dynamic import on client-side 😁 But, even there I think it is good to give users of the lib the ability to bundle the code

@tekigg
Copy link

tekigg commented Dec 6, 2023

Nice! It’s what I ended up doing as well. And yeah wouldn’t hurt to have them exported would probably also make implementation easier. Thanks for the help!

@schardev
Copy link

@devenini If (for some reason) this is not an ideal solution then could you at least ship non-minified files? I could easily patch source files instead of maintaining my own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants