Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Effectively interrupt auto scrolling #2223

Merged
merged 18 commits into from Apr 30, 2024
Merged

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented Apr 26, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

原先当流畅生成文字时,由于元素持续渲染,导致向上滚动一次鼠标很难阻止自动滚动。

(滚动多次有效,但会出现同时上滚下滚的对抗)

添加了检测到 鼠标滚动/屏幕滑动 即暂停自动滚动的特性,滚动/滑动结束即恢复。

修复了当发送新对话时,不会自动跳转底部的问题。

📝 补充信息 | Additional Information

经测试,建议一并修改下面值以提升体验。

  • atBottomThreshold :较大的阈值导致即便向上划了一段距离,依旧能激活自动滚动。尤其在移动端突出。
    缺点则是“跳转至当前”按钮会更容易出现。

  • overscan : 似乎存在优化问题,待进一步检查。

大概是 Virtuoso 自身问题,移动端当屏幕滑动时会暂停渲染更新,导致松开后的卡顿与移位,不考虑修复。

Copy link

vercel bot commented Apr 26, 2024

@sxjeru is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @sxjeru

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (a2b931f) to head (dfc2023).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2223    +/-   ##
========================================
  Coverage   92.68%   92.68%            
========================================
  Files         290      290            
  Lines       16579    16579            
  Branches     1911     1191   -720     
========================================
  Hits        15366    15366            
  Misses       1213     1213            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 5:06pm

@arvinxx arvinxx merged commit afe4974 into lobehub:main Apr 30, 2024
6 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @sxjeru ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
### [Version 0.151.5](v0.151.4...v0.151.5)
<sup>Released on **2024-04-30**</sup>

#### 🐛 Bug Fixes

- **misc**: Effectively interrupt auto scrolling.

#### 💄 Styles

- **misc**: Revise some text.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Effectively interrupt auto scrolling, closes [#2223](#2223) ([afe4974](afe4974))

#### Styles

* **misc**: Revise some text, closes [#2296](#2296) ([018427f](018427f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.151.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Apr 30, 2024
### [Version&nbsp;1.31.1](v1.31.0...v1.31.1)
<sup>Released on **2024-04-30**</sup>

#### ♻ Code Refactoring

- **misc**: Move app page to the `(main)` layout group.

#### 🐛 Bug Fixes

- **misc**: Effectively interrupt auto scrolling, fix only inject welcome question in inbox, plugins with multiple settings cannot be correctly configured.

#### 💄 Styles

- **misc**: Add 404 and Error page, patching models info, Revise some text.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Move app page to the `(main)` layout group, closes [lobehub#2297](https://github.com/bentwnghk/lobe-chat/issues/2297) ([6cc2c38](6cc2c38))

#### What's fixed

* **misc**: Effectively interrupt auto scrolling, closes [lobehub#2223](https://github.com/bentwnghk/lobe-chat/issues/2223) ([afe4974](afe4974))
* **misc**: Fix only inject welcome question in inbox, closes [lobehub#2289](https://github.com/bentwnghk/lobe-chat/issues/2289) ([cc8edd3](cc8edd3))
* **misc**: Plugins with multiple settings cannot be correctly configured, closes [lobehub#1991](https://github.com/bentwnghk/lobe-chat/issues/1991) ([0c041aa](0c041aa))

#### Styles

* **misc**: Add 404 and Error page, closes [lobehub#2299](https://github.com/bentwnghk/lobe-chat/issues/2299) ([938a3e9](938a3e9))
* **misc**: Patching models info, closes [lobehub#2269](https://github.com/bentwnghk/lobe-chat/issues/2269) [#22802280](https://github.com/bentwnghk/lobe-chat/issues/22802280) ([03bcb06](03bcb06))
* **misc**: Revise some text, closes [lobehub#2296](https://github.com/bentwnghk/lobe-chat/issues/2296) ([018427f](018427f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@sxjeru sxjeru deleted the remote branch May 2, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] [体验建议] 发送消息后,Chat 自动滚动到最下方
3 participants