🐛 fix: disabled autogenerate field icon when empty system role #2076

techcontributor · 2024-04-17T09:52:28Z

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

Disabled the auto generate icon when system role is empty

fixes #2052

vercel · 2024-04-17T09:52:31Z

Someone is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

lobehubbot · 2024-04-17T09:52:40Z

👍 @techcontributor

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

sagar-vaghela · 2024-04-23T10:43:17Z

@gijigae @lobehubbot @phuang07 @chenhunghan

Could you please review this PR?

vercel · 2024-04-25T07:30:40Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lobe-chat-community	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 3, 2024 11:05am

codecov · 2024-04-25T07:33:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (88d0e39) to head (56cbc3b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2076   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files         295      295           
  Lines       16791    16791           
  Branches     1939     1939           
=======================================
  Hits        15593    15593           
  Misses       1198     1198

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arvinxx · 2024-04-25T07:53:19Z

@techcontributor vercel build failed, please check the code

techcontributor · 2024-04-25T11:43:01Z

@techcontributor vercel build failed, please check the code

@arvinxx could you please check now? i updated PR

Thanks

arvinxx · 2024-04-29T03:55:24Z

src/features/AgentSetting/store/action.ts

why remove the systemRole condition?

@arvinxx

it was for extra guard check condition but i hope this is not require any more since it is already been disabled in code using canAutoGenerate. (please find attachment)

but if you think this is required then i will put it back.

I think it's required, because we have another place to call these functions like autocompleteMeta. And maybe in the future we will call it automatically when user just set system role in the chat page. so the guard is necessary

Okay i made update as per feedback please check PR once.

@arvinxx

why update the const preValue = meta.description; line? I think this file don't need to change.

techcontributor · 2024-05-02T12:39:23Z

@arvinxx could you please review this PR?

if all good then could you please proceed ahead? or let me know if any query

arvinxx · 2024-05-02T12:40:39Z

@techcontributor I have commented.

techcontributor · 2024-05-02T12:47:29Z

@techcontributor I have commented.

@arvinxx could you please check my comment? i already reply

arvinxx · 2024-05-02T13:43:24Z

@techcontributor It's pending , so I didn't see it. you need to send it.

like this:

techcontributor · 2024-05-02T14:03:32Z

@techcontributor It's pending , so I didn't see it. you need to send it.
like this:

submitted @arvinxx

…nto fix/autogenerate-fields

arvinxx

I think the change of AgentMeta is LGTM, please revert the change of the action.ts

…ributor/lobe-chat into fix/autogenerate-fields

techcontributor · 2024-05-03T10:43:20Z

action.ts

@arvinxx reverted the changes as per suggestion.

arvinxx · 2024-05-03T10:45:10Z

@techcontributor OK, I have triggered the vercel deployment. And I'll check the preview and if it works as expected, I'll merge it~ Thanks for your patience and contribution~ 👏

lobehubbot · 2024-05-04T02:46:28Z

❤️ Great PR @techcontributor ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

### [Version 0.152.12](v0.152.11...v0.152.12) <sup>Released on **2024-05-04**</sup> #### 🐛 Bug Fixes - **misc**: Disabled autogenerate field icon when empty system role. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Disabled autogenerate field icon when empty system role, closes [#2076](#2076) ([27095f5](27095f5)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

lobehubbot · 2024-05-04T02:50:10Z

🎉 This PR is included in version 0.152.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

### [Version 1.32.2](v1.32.1...v1.32.2) <sup>Released on **2024-05-04**</sup> #### ♻ Code Refactoring - **misc**: Refactor Setting Layout, user store add an auth slice. #### 🐛 Bug Fixes - **misc**: Disabled autogenerate field icon when empty system role, Fix intercepting-routes on mobile, Fix router path in UserPanel, Fix Setings Layout, Fix undefined 'DISCORD', Test CI and Release CI, Test CI and Release CI, Test CI and Release CI, Test CI and Release CI, Test CI and Release CI. #### 💄 Styles - **misc**: Add user panel and refactor the next-auth, autoScroll to the fully end, improve market layout styles and mobile style, refactor setting layout and improve setting design. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Refactor Setting Layout, closes [lobehub#2336](https://github.com/bentwnghk/lobe-chat/issues/2336) ([282082e](282082e)) * **misc**: User store add an auth slice, closes [lobehub#2214](https://github.com/bentwnghk/lobe-chat/issues/2214) ([948b257](948b257)) #### What's fixed * **misc**: Disabled autogenerate field icon when empty system role, closes [lobehub#2076](https://github.com/bentwnghk/lobe-chat/issues/2076) ([27095f5](27095f5)) * **misc**: Fix intercepting-routes on mobile ([abe228c](abe228c)) * **misc**: Fix router path in UserPanel ([c779e02](c779e02)) * **misc**: Fix Setings Layout, closes [lobehub#2340](https://github.com/bentwnghk/lobe-chat/issues/2340) ([6a2e9a9](6a2e9a9)) * **misc**: Fix undefined 'DISCORD' ([41c70be](41c70be)) * **misc**: Test CI and Release CI ([a909afe](a909afe)) * **misc**: Test CI and Release CI ([aff22b5](aff22b5)) * **misc**: Test CI and Release CI ([1db3b59](1db3b59)) * **misc**: Test CI and Release CI ([e0c82c8](e0c82c8)) * **misc**: Test CI and Release CI ([97634ca](97634ca)) #### Styles * **misc**: Add user panel and refactor the next-auth, closes [lobehub#2349](https://github.com/bentwnghk/lobe-chat/issues/2349) ([5cecee0](5cecee0)) * **misc**: AutoScroll to the fully end, closes [lobehub#2345](https://github.com/bentwnghk/lobe-chat/issues/2345) ([5458e98](5458e98)) * **misc**: Improve market layout styles and mobile style, closes [lobehub#2347](https://github.com/bentwnghk/lobe-chat/issues/2347) ([79b8115](79b8115)) * **misc**: Refactor setting layout and improve setting design, closes [lobehub#2344](https://github.com/bentwnghk/lobe-chat/issues/2344) ([fa16721](fa16721)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

vercel bot had a problem deploying to Preview April 25, 2024 07:51 Failure

fix: disabled autogenerate field icon when empty system role

cf7d640

sagar-vaghela force-pushed the fix/autogenerate-fields branch from 8c5a6f4 to cf7d640 Compare April 25, 2024 11:41

arvinxx changed the title ~~fix: disabled autogenerate field icon when empty system role~~ 🐛 fix: disabled autogenerate field icon when empty system role Apr 26, 2024

arvinxx reviewed Apr 29, 2024

View reviewed changes

techcontributor requested a review from arvinxx May 2, 2024 12:48

techcontributor and others added 3 commits May 3, 2024 12:10

Merge branch 'main' of https://github.com/techcontributor/lobe-chat i…

36f18d6

…nto fix/autogenerate-fields

🐛 fix: update systemrole guard

9f85b6d

Merge branch 'main' into fix/autogenerate-fields

fbc2159

arvinxx reviewed May 3, 2024

View reviewed changes

techcontributor added 3 commits May 3, 2024 16:10

🐛 fix: revert action.ts file change

76f8112

Merge branch 'fix/autogenerate-fields' of https://github.com/techcont…

028cef9

…ributor/lobe-chat into fix/autogenerate-fields

🐛 fix: added space

56cbc3b

vercel bot deployed to Preview May 3, 2024 11:05 View deployment

techcontributor requested a review from arvinxx May 3, 2024 13:04

arvinxx merged commit 27095f5 into lobehub:main May 4, 2024
6 checks passed

lobehubbot added the released label May 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 fix: disabled autogenerate field icon when empty system role #2076

🐛 fix: disabled autogenerate field icon when empty system role #2076

techcontributor commented Apr 17, 2024 •

edited

vercel bot commented Apr 17, 2024

lobehubbot commented Apr 17, 2024

sagar-vaghela commented Apr 23, 2024

vercel bot commented Apr 25, 2024 •

edited

codecov bot commented Apr 25, 2024 •

edited

arvinxx commented Apr 25, 2024

techcontributor commented Apr 25, 2024

arvinxx Apr 29, 2024

techcontributor Apr 29, 2024

arvinxx May 2, 2024 •

edited

techcontributor May 3, 2024

arvinxx May 3, 2024 •

edited

techcontributor commented May 2, 2024

arvinxx commented May 2, 2024 •

edited

techcontributor commented May 2, 2024

arvinxx commented May 2, 2024 •

edited

techcontributor commented May 2, 2024 •

edited

arvinxx left a comment

techcontributor commented May 3, 2024

arvinxx commented May 3, 2024 •

edited

lobehubbot commented May 4, 2024

lobehubbot commented May 4, 2024

🐛 fix: disabled autogenerate field icon when empty system role #2076

🐛 fix: disabled autogenerate field icon when empty system role #2076

Conversation

techcontributor commented Apr 17, 2024 • edited

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

vercel bot commented Apr 17, 2024

lobehubbot commented Apr 17, 2024

sagar-vaghela commented Apr 23, 2024

vercel bot commented Apr 25, 2024 • edited

codecov bot commented Apr 25, 2024 • edited

Codecov Report

arvinxx commented Apr 25, 2024

techcontributor commented Apr 25, 2024

arvinxx Apr 29, 2024

Choose a reason for hiding this comment

techcontributor Apr 29, 2024

Choose a reason for hiding this comment

arvinxx May 2, 2024 • edited

Choose a reason for hiding this comment

techcontributor May 3, 2024

Choose a reason for hiding this comment

arvinxx May 3, 2024 • edited

Choose a reason for hiding this comment

techcontributor commented May 2, 2024

arvinxx commented May 2, 2024 • edited

techcontributor commented May 2, 2024

arvinxx commented May 2, 2024 • edited

techcontributor commented May 2, 2024 • edited

arvinxx left a comment

Choose a reason for hiding this comment

techcontributor commented May 3, 2024

arvinxx commented May 3, 2024 • edited

lobehubbot commented May 4, 2024

lobehubbot commented May 4, 2024

techcontributor commented Apr 17, 2024 •

edited

vercel bot commented Apr 25, 2024 •

edited

codecov bot commented Apr 25, 2024 •

edited

arvinxx May 2, 2024 •

edited

arvinxx May 3, 2024 •

edited

arvinxx commented May 2, 2024 •

edited

arvinxx commented May 2, 2024 •

edited

techcontributor commented May 2, 2024 •

edited

arvinxx commented May 3, 2024 •

edited