New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow to select another model provider for translation action #1902
base: main
Are you sure you want to change the base?
Conversation
@phsontung is attempting to deploy a commit to the LobeHub Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for raising your pull request and contributing to our Community |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1902 +/- ##
==========================================
+ Coverage 92.87% 92.89% +0.01%
==========================================
Files 296 296
Lines 16872 16914 +42
Branches 1948 1208 -740
==========================================
+ Hits 15670 15712 +42
Misses 1202 1202 ☔ View full report in Codecov by Sentry. |
@phsontung hello, sorry for the later reply. Please rebase the config. |
I have synced with main branch and update source code. Please help review bro. |
@phsontung I think it's really a great idea to have system agent config for LobeChat. but I prefer a single tab Named "System Agent" for this. So we can set different models to summarize, translate, auto agent meta and so on. And in this PR just adding translate config is fine. |
@@ -151,6 +153,13 @@ export const DEFAULT_TTS_CONFIG: GlobalTTSConfig = { | |||
sttServer: 'openai', | |||
}; | |||
|
|||
export const DEFAULT_TRANSLATION_CONFIG: GlobalTranslationConfig = { | |||
model: DEFAULT_AGENT_CONFIG.model, | |||
provider: DEFAULT_AGENT_CONFIG.provider || ModelProvider.OpenAI, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just set as OpenAI
@@ -48,12 +53,19 @@ export const chatEnhance: StateCreator< | |||
topicId: get().activeTopicId, | |||
...data, | |||
}), | |||
getCurrentTranslationSetting: () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this method is not used in somewhere else? maybe we can remove it?
18aff06
to
4b92e84
Compare
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
📝 补充信息 | Additional Information