Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 wip: test gemini function call #1810

Closed
wants to merge 2 commits into from
Closed

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Mar 29, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

support gemini function call

📝 补充信息 | Additional Information

Google 的返回逻辑很怪,还没发支持。感觉得等后续 stream 请求改造完才能支持了

@arvinxx arvinxx marked this pull request as draft March 29, 2024 13:59
Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat ❌ Failed (Inspect) Mar 29, 2024 3:58pm

@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@coderphonui
Copy link

The stream is not working with function call because of this line: https://github.com/vercel/ai/blob/68fd43d0ca6a843ee1e5c42a723069da8922aad7/packages/core/streams/google-generative-ai-stream.ts#L45

GoogleGenerativeAIStream does not return the stream content if it's not a string. Checking carefully the case of function calling, the return data is not text in that case. We need to ask Vercel to fix this bug

@arvinxx
Copy link
Contributor Author

arvinxx commented May 10, 2024

@coderphonui don't worry, I fix it in the PR: #2414

@arvinxx arvinxx closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Function calling for gemini-pro
3 participants