💄 style: add two feature flags: check_updates 、welcome_suggest (#2555)

* feat: add two feature flags: check_updates 、welcome_suggest * refactor code * refactor code * refactor code * remove unused code * fix test code * optimize code
lobehub · May 19, 2024 · 84c69c9 · 84c69c9
1 parent 54cf16a
commit 84c69c9
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 11 deletions.
diff --git a/src/config/featureFlags/index.test.ts b/src/config/featureFlags/index.test.ts
@@ -36,6 +36,8 @@ describe('mapFeatureFlagsEnvToState', () => {
       create_session: true,
       edit_agent: false,
       dalle: true,
+      check_updates: true,
+      welcome_suggest: true,
     };
 
     const expectedState = {
@@ -46,6 +48,8 @@ describe('mapFeatureFlagsEnvToState', () => {
       showOpenAIApiKey: true,
       showOpenAIProxyUrl: false,
       showDalle: true,
+      enableCheckUpdates: true,
+      showWelcomeSuggest: true,
     };
 
     const mappedState = mapFeatureFlagsEnvToState(config);

diff --git a/src/config/featureFlags/index.ts b/src/config/featureFlags/index.ts
@@ -13,6 +13,9 @@ export const FeatureFlagsSchema = z.object({
   edit_agent: z.boolean().optional(),
 
   dalle: z.boolean().optional(),
+
+  check_updates: z.boolean().optional(),
+  welcome_suggest: z.boolean().optional(),
 });
 
 // TypeScript 类型，从 Zod schema 生成
@@ -30,6 +33,9 @@ export const DEFAULT_FEATURE_FLAGS: IFeatureFlags = {
   edit_agent: true,
 
   dalle: true,
+
+  check_updates: true,
+  welcome_suggest: true,
 };
 
 export const mapFeatureFlagsEnvToState = (config: IFeatureFlags) => {
@@ -44,5 +50,8 @@ export const mapFeatureFlagsEnvToState = (config: IFeatureFlags) => {
     showOpenAIProxyUrl: config.openai_proxy_url,
 
     showDalle: config.dalle,
+
+    enableCheckUpdates: config.check_updates,
+    showWelcomeSuggest: config.welcome_suggest,
   };
 };
diff --git a/src/features/Conversation/components/InboxWelcome/index.tsx b/src/features/Conversation/components/InboxWelcome/index.tsx
@@ -7,7 +7,7 @@ import { useTranslation } from 'react-i18next';
 import { Center, Flexbox } from 'react-layout-kit';
 
 import { useGreeting } from '@/hooks/useGreeting';
-import { useServerConfigStore } from '@/store/serverConfig';
+import { featureFlagsSelectors, useServerConfigStore } from '@/store/serverConfig';
 
 import AgentsSuggest from './AgentsSuggest';
 import QuestionSuggest from './QuestionSuggest';
@@ -44,6 +44,7 @@ const InboxWelcome = memo(() => {
   const { styles } = useStyles();
   const mobile = useServerConfigStore((s) => s.isMobile);
   const greeting = useGreeting();
+  const { showWelcomeSuggest } = useServerConfigStore(featureFlagsSelectors);
 
   return (
     <Center padding={16} width={'100%'}>
@@ -55,8 +56,12 @@ const InboxWelcome = memo(() => {
         <Markdown className={styles.desc} variant={'chat'}>
           {t('guide.defaultMessage')}
         </Markdown>
-        <AgentsSuggest mobile={mobile} />
-        <QuestionSuggest mobile={mobile} />
+        {
+          showWelcomeSuggest && <>
+            <AgentsSuggest mobile={mobile} />
+            <QuestionSuggest mobile={mobile} />
+          </>
+        }
       </Flexbox>
     </Center>
   );

diff --git a/src/features/User/UserPanel/useNewVersion.tsx b/src/features/User/UserPanel/useNewVersion.tsx
@@ -1,12 +1,14 @@
 import { useGlobalStore } from '@/store/global';
+import { featureFlagsSelectors, useServerConfigStore } from '@/store/serverConfig';
 
 export const useNewVersion = () => {
   const [hasNewVersion, useCheckLatestVersion] = useGlobalStore((s) => [
     s.hasNewVersion,
     s.useCheckLatestVersion,
   ]);
 
-  useCheckLatestVersion();
+  const { enableCheckUpdates } = useServerConfigStore(featureFlagsSelectors);
+  useCheckLatestVersion(enableCheckUpdates);
 
   return hasNewVersion;
 };
diff --git a/src/features/User/__tests__/useMenu.test.tsx b/src/features/User/__tests__/useMenu.test.tsx
@@ -2,9 +2,13 @@ import { act, renderHook } from '@testing-library/react';
 import { describe, expect, it, vi } from 'vitest';
 
 import { useUserStore } from '@/store/user';
+import { ServerConfigStoreProvider } from '@/store/serverConfig';
 
 import { useMenu } from '../UserPanel/useMenu';
 
+const wrapper: React.JSXElementConstructor<{ children: React.ReactNode }> = ({ children }) =>
+  <ServerConfigStoreProvider>{children}</ServerConfigStoreProvider>
+
 // Mock dependencies
 vi.mock('next/link', () => ({
   default: vi.fn(({ children }) => <div>{children}</div>),
@@ -69,7 +73,7 @@ describe('useMenu', () => {
     enableAuth = true;
     enableClerk = false;
 
-    const { result } = renderHook(() => useMenu());
+    const { result } = renderHook(() => useMenu(), { wrapper });
 
     act(() => {
       const { mainItems, logoutItems } = result.current;
@@ -89,7 +93,7 @@ describe('useMenu', () => {
     enableAuth = true;
     enableClerk = true;
 
-    const { result } = renderHook(() => useMenu());
+    const { result } = renderHook(() => useMenu(), { wrapper });
 
     act(() => {
       const { mainItems, logoutItems } = result.current;
@@ -108,7 +112,7 @@ describe('useMenu', () => {
     });
     enableAuth = false;
 
-    const { result } = renderHook(() => useMenu());
+    const { result } = renderHook(() => useMenu(), { wrapper });
 
     act(() => {
       const { mainItems, logoutItems } = result.current;
@@ -127,7 +131,7 @@ describe('useMenu', () => {
     });
     enableAuth = true;
 
-    const { result } = renderHook(() => useMenu());
+    const { result } = renderHook(() => useMenu(), { wrapper });
 
     act(() => {
       const { mainItems, logoutItems } = result.current;

diff --git a/src/store/global/action.ts b/src/store/global/action.ts
@@ -27,7 +27,7 @@ export interface GlobalStoreAction {
   toggleMobileTopic: (visible?: boolean) => void;
   toggleSystemRole: (visible?: boolean) => void;
   updatePreference: (preference: Partial<GlobalPreference>, action?: any) => void;
-  useCheckLatestVersion: () => SWRResponse<string>;
+  useCheckLatestVersion: (enabledCheck?: boolean) => SWRResponse<string>;
   useInitGlobalPreference: () => SWRResponse;
 }
 
@@ -79,8 +79,8 @@ export const globalActionSlice: StateCreator<
     get().preferenceStorage.saveToLocalStorage(nextPreference);
   },
 
-  useCheckLatestVersion: () =>
-    useSWR('checkLatestVersion', globalService.getLatestVersion, {
+  useCheckLatestVersion: (enabledCheck = true) =>
+    useSWR(enabledCheck ? 'checkLatestVersion' : null, globalService.getLatestVersion, {
       // check latest version every 30 minutes
       focusThrottleInterval: 1000 * 60 * 30,
       onSuccess: (data: string) => {

diff --git a/src/store/serverConfig/selectors.test.ts b/src/store/serverConfig/selectors.test.ts
@@ -24,6 +24,8 @@ describe('featureFlagsSelectors', () => {
       showLLM: false,
       showOpenAIApiKey: true,
       showOpenAIProxyUrl: true,
+      enableCheckUpdates: true,
+      showWelcomeSuggest: true,
     });
   });
 });