New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): add dialog component #68
base: main
Are you sure you want to change the base?
Conversation
|
@sonnyt is attempting to deploy a commit to the Lemon Squeezy Team on Vercel. A member of the Team first needs to authorize it. |
Hey @sonnyt, Thank you for your contribution. It seems like you're headed in the right direction! Here are a few comments: You've used some Tailwind utilities that do not exist. These animation classes are available through the Wedges Tailwind CSS plugin:
We don't provide these: Also, Close button I'd use the Wedges Button component for the Dialog Close component to maintain consistency with the design. |
DialogContent.displayName = "DialogContent"; | ||
DialogOverlay.displayName = "DialogOverlay"; | ||
|
||
const Dialog = Object.assign(DialogPrimitive.Root, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea behind Wedges components is to provide a versatile yet easy to use component for common use cases, equipped with the most useful props. Also, there is an option to enhance and personalize these components through the composition of additional components.
For instance, the Dialog
component can be used as follows:
<Dialog title="Title" isOpen={true}>
Content
</Dialog>
For more advanced use cases, the component can be composed with other components:
<Dialog.Root>
<Dialog.Title>Title</Dialog.Title>
<Dialog.Content>
Content
</Dialog.Content>
...
</Dialog.Root>
This flexibility allows for both easy implementation in straightforward scenarios and customizable complexity when needed.
```suggestion
const Dialog = Object.assign(DialogPrimitive.Root, {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
I will work on it next week :)
Started to add a dialog component. This is a still work in progress.
Am I heading the right direction @brankoconjic ? 😃