Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes #223

Merged
merged 1 commit into from
Jun 2, 2024
Merged

changes #223

merged 1 commit into from
Jun 2, 2024

Conversation

andrewgsavage
Copy link
Contributor

No description provided.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (3255816) to head (4ff73bf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files          12       12           
  Lines        1905     1905           
=======================================
  Hits         1824     1824           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@newville newville mentioned this pull request May 16, 2024
Copy link
Member

@newville newville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Should we adopt a "more conventional" Changelog with a heading for each version (with date) and then lists of "bug fixes" and "new features"? I think that was suggested at some point.... But I also get that it can be some work ;)

@wshanks
Copy link
Collaborator

wshanks commented May 16, 2024

I had suggested something more systematic in #215 but I have not worked on it so far (no objections to doing this for now).

@andrewgsavage
Copy link
Contributor Author

andrewgsavage commented May 16, 2024 via email

@newville newville merged commit cf62fdf into lmfit:master Jun 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants