Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numba call for deprecation of nopython=True #1061

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aarmey
Copy link

@aarmey aarmey commented Oct 5, 2023

Fixes #1048 for umap.plot.

I think this line was missed during the changes in v0.5.4.

@lmcinnes
Copy link
Owner

lmcinnes commented Oct 5, 2023

This is actually a nopython=False case; I think in practice it probably needs to be updated to use the python object context handling that has been added to numba. I'll try to get around to that in due course.

@pep8speaks
Copy link

Hello @aarmey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 209:89: E501 line too long (92 > 88 characters)

@aarmey
Copy link
Author

aarmey commented Oct 6, 2023

@lmcinnes you might want to avoid the additional complexity, but here is a version that can be fully compiled by Numba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numba.jit and numpy dependency problems
3 participants