Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numba.jit and numpy dependency problems #1048

Closed
ekwan opened this issue Aug 31, 2023 · 4 comments · May be fixed by #1061
Closed

Numba.jit and numpy dependency problems #1048

ekwan opened this issue Aug 31, 2023 · 4 comments · May be fixed by #1061

Comments

@ekwan
Copy link

ekwan commented Aug 31, 2023

Hi, I'm getting this warning with umap 0.5.3:

  @numba.jit()
/Users/kwaneu/sw/miniconda/miniconda3/envs/python/lib/python3.11/site-packages/umap/umap_.py:660: NumbaDeprecationWarning: The 'nopython' keyword argument was not supplied to the 'numba.jit' decorator. The implicit default value for this argument is currently False, but it will be changed to True in Numba 0.59.0. See https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-object-mode-fall-back-behaviour-when-using-jit for details.

I'm also seeing umap complain it only supports up to numpy 1.24.0.
@mbelak-dtml
Copy link

This is already fixed on main by 8a94182.
However, this is not released yet.

@lmcinnes Any plans for releasing?

@lmcinnes
Copy link
Owner

There should be a new release out now, and hopefully this is now resolved.

@mbelak-dtml
Copy link

@ekwan The issue is resolved in the latest release. Can we close this?

mbelak-dtml added a commit to datamole-ai/edvart that referenced this issue Sep 18, 2023
@mbelak-dtml
chore: require new umap-learn
1053a33 
Fixes a warning which was present in umap-learn 0.5.3.
See lmcinnes/umap#1048
@mbelak-dtml mbelak-dtml mentioned this issue Sep 18, 2023
Merged
github-merge-queue bot pushed a commit to datamole-ai/edvart that referenced this issue Sep 18, 2023
@mbelak-dtml
chore: require new umap-learn (#132)
2ed9862 
Fixes a warning which was present in umap-learn 0.5.3. See
lmcinnes/umap#1048
@ekwan
Copy link
Author

ekwan commented Sep 18, 2023

Checked and this has fixed the problem! Thank you!

@ekwan ekwan closed this as completed Sep 18, 2023
@aarmey aarmey mentioned this issue Oct 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix numba call for deprecation of nopython=True aarmey/umap
3 participants
@ekwan @lmcinnes @mbelak-dtml