support more LaTeX delimiters #3335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Certain advanced models, such as GPT/Yi, have the capability to generate LaTeX formulas enclosed within
\[...\], but this format is not support yet. This PR add more LaTeX delimiters for better display format in Chatbot Arena.However, there is a bug while specific this
latex_delimiters_setin stream mode, as mentioned in gradio-app/gradio#8006, we should wait the bug fixed then test and merge this PRUpdate:
Above bug will not trigger after offline deployed webui test. But there is another bug that markdown is treating
\as escape character first, so\\[will be rendered as[first, then it will not match LaTeX delimiters defined inlatex_delimiters_set. The solution might be escape model output by replace\\[with\\\\[before render...Related issue number (if applicable)
Checks
format.shto lint the changes in this PR.