New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vllm_worker.py #3330

Open

jbding wants to merge 1 commit into lm-sys:main from jbding:main

jbding commented May 13, 2024

Why are these changes needed?

The vllm_worker code does not catch exceptions: when I check vllm's SamplingParams function, there is parameter verification and the error ValueError is thrown out.
Because there is no capture, the semaphore is not released after the code execution fails, causing the model to fail to work.

Related issue number (if applicable)

Checks

[ ✓] I've run format.sh to lint the changes in this PR.
[ ✗] I've included any doc changes needed.
[ ✓] I've made sure the relevant tests are passing (if applicable).


          Add exception capture to vllm worker fix lm-sys#3328

dd2470c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment