Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error and support Phi-3 models #3318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renning22
Copy link
Contributor

@renning22 renning22 commented May 7, 2024

Why are these changes needed?

Model worker (also vllm_worker) has error loading Phi-3 models "microsoft/Phi-3-mini-128k-instruct" etc..
Screenshot from 2024-05-07 00-58-23

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

@renning22
Copy link
Contributor Author

@merrymercy @Ying1123 PTAL, thanks~

icowan added a commit to icowan/FastChat that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant