Fix port in worker-address in vllm_worker for #2467 #3300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When just change
--port
, it has no error but it does not work well when run sevural models in one machine.And this does not change the behavior when explicitly specify the
-worker-address
.Why are these changes needed?
When running more than one model with one controller in one machine, changing
--port
is a natural behavior.This a more frequent case should be supported.
Related issue number
Open #2467"
Checks
format.sh
to lint the changes in this PR.