Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fix for the Chinese-Alpaca-2-7B model matches the wrong AlpacaAda… #3251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

linstreamer
Copy link

@linstreamer linstreamer commented Apr 18, 2024

The fix for the Chinese-Alpaca-2-7B model matches the wrong AlpacaAdapter instead of the correct Llama2ChineseAlpacaAdapter.

Why are these changes needed?

图片

    def match(self, model_path: str):
-        return "alpaca" in model_path.lower()
+        return "alpaca" in model_path.lower() and "chinese-alpaca" not in model_path.lower()

Related issue number (if applicable)

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

…pter instead of the correct Llama2ChineseAlpacaAdapter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant