Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds a new template for H2O-Danube such as:
https://huggingface.co/h2oai/h2o-danube2-1.8b-chat
Additionally, I have updated a few minor things:
conv = get_conversation_template(model_id)
toconv = get_conversation_template(model_path)
to get the correct model template. This will always make sure the template is extracted from the actual model name on HF, and not based on the id one applies locally.input_ids
andattention_mask
to the model forward which is the clean way of doing it, some models complain otherwise..gitignore
to not push alljsonl
files from generation