Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2O-Danube template & minor fixes #3231

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

psinger
Copy link

@psinger psinger commented Apr 9, 2024

Why are these changes needed?

This PR adds a new template for H2O-Danube such as:
https://huggingface.co/h2oai/h2o-danube2-1.8b-chat

Additionally, I have updated a few minor things:

  • Changed conv = get_conversation_template(model_id) to conv = get_conversation_template(model_path) to get the correct model template. This will always make sure the template is extracted from the actual model name on HF, and not based on the id one applies locally.
  • Add both input_ids and attention_mask to the model forward which is the clean way of doing it, some models complain otherwise.
  • Updated the .gitignore to not push all jsonl files from generation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant