chore: let conv.message be str if no image provided in request #3225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When using langchaingo w/ fastchat, it generates requests with formats like
"messages":["text":"given text", "type": "text"]
as default, which will be recognized and processed as a request with image since JSON sees it as a list(dict), therefore causing errors atprompt = conv.get_prompt()
since most model adapters for normal LLMs could not acceptconv.messages
aslist[tuple]
.By adopting this fix, requests will plain texts would be correctly recognized and appended to
conv
as str.Related issue number (if applicable)
Checks
format.sh
to lint the changes in this PR.