Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch] eliminate "getWithLeastStaticInformation" in DecomposeAtenTriuOp #3330

Merged
merged 7 commits into from May 22, 2024

Conversation

Xinyu302
Copy link
Contributor

I am trying to eliminate 'getWithLeastStaticInformation' in DecomposeAtenTriuOp. Could you provide me with some suggestions?
@qingyunqu @zjgarvey
See issue #3312

@zjgarvey zjgarvey self-requested a review May 13, 2024 17:49
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Xinyu302 ! The helper functions you defined look very convenient, so thanks for adding those.

I have one small change to request, but otherwise this looks good to me.

lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp Outdated Show resolved Hide resolved
@Xinyu302 Xinyu302 requested a review from zjgarvey May 14, 2024 07:05
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

include/torch-mlir/Dialect/Torch/Utils/Utils.h Outdated Show resolved Hide resolved
@Xinyu302 Xinyu302 requested a review from renxida May 15, 2024 05:20
Copy link
Collaborator

@renxida renxida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, approved!

@qingyunqu qingyunqu merged commit 4d7cdba into llvm:main May 22, 2024
3 checks passed
BaneTrifa pushed a commit to BaneTrifa/torch-mlir that referenced this pull request May 24, 2024
…uOp (llvm#3330)

I am trying to eliminate 'getWithLeastStaticInformation' in
DecomposeAtenTriuOp. Could you provide me with some suggestions?
@qingyunqu @zjgarvey 
See issue llvm#3312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants