Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul TestingGuide page #190

Merged
merged 6 commits into from May 16, 2024
Merged

Conversation

j2kun
Copy link
Contributor

@j2kun j2kun commented May 9, 2024

@joker-eph

The main change is to separate the doc into logical sections for:

  • Quick command reference
  • Description of the different test types (what)
  • Contributor guidelines (how and why)

@j2kun
Copy link
Contributor Author

j2kun commented May 9, 2024

Attached the rendered HTML for easier reading
testing-guide-draft.pdf

Copy link
Contributor

@joker-eph joker-eph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a quick skim right now. Please have a look at #189 as well.

website/content/getting_started/TestingGuide.md Outdated Show resolved Hide resolved
website/content/getting_started/TestingGuide.md Outdated Show resolved Hide resolved
website/content/getting_started/TestingGuide.md Outdated Show resolved Hide resolved
j2kun and others added 3 commits May 9, 2024 09:53
Co-authored-by: Mehdi Amini <joker.eph@gmail.com>
Co-authored-by: Mehdi Amini <joker.eph@gmail.com>
@j2kun
Copy link
Contributor Author

j2kun commented May 15, 2024

@joker-eph any final thoughts on this?

Copy link
Contributor

@joker-eph joker-eph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall, thanks!

website/content/getting_started/TestingGuide.md Outdated Show resolved Hide resolved
@j2kun
Copy link
Contributor Author

j2kun commented May 16, 2024

@joker-eph I will need you to merge the changes as I don't have merge permissions on this repo.

@joker-eph joker-eph merged commit ca82546 into llvm:main May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants