llvm-hs-pure: work with bytestring 0.11.x #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - Relaxes the version bound on bytestring for llvm-hs-pure - Fixes a couple trivial build errors due to ambiguous symbol resoltions; bytestring 0.11 added some functions called snoc, foldr and such.
zenhack
added a commit
to Glow-Lang/glow2-haskell
that referenced
this pull request
Mar 17, 2022
1. The current version isn't on hackage yet, see llvm-hs/llvm-hs#369 2. We needed to patch the version bounds to get this to build with our other dependencies; see llvm-hs/llvm-hs#389
|
For me - bytestring >= 0.10 && < 0.11,
+ bytestring >= 0.10 && < 0.12, |
|
I just saw this MR, sorry, I've done the same in #406. |
|
As a Hackage trustee I made a revision, allowing to build |
|
@Bodigrim, does it actually build with those versions? I'm thoroughly context-switched out at this point, but this patch actually has some (minor) code changes, rather than just bumping the version. |
|
@zenhack it does. The revision allows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
resoltions; bytestring 0.11 added some functions called snoc,
foldr and such.
It would probably make sense to do the same for llvm-hs, but I am having trouble getting it to build against my local version of llvm, so decided to punt for now; for my own project I may end up just shelling out to
llcrather than try to link against the library.