Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: create actions to publish crates #578

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

github: create actions to publish crates #578

wants to merge 4 commits into from

Conversation

nitnelave
Copy link
Member

No description provided.

needs: pre_job
steps:
- uses: actions/checkout@v3.5.2
- uses: actions-rs/toolchain@v1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we might want (in a future PR) to migrate our rust installation to this action instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually you probably don't want to use actions-rs because its unmaintained

@nitnelave nitnelave force-pushed the crates branch 4 times, most recently from 451c445 to ea447e8 Compare May 12, 2023 13:12
@nitnelave
Copy link
Member Author

We're hitting katyo/publish-crates#660 so I had to get rid of the wildcard versions.

@martadinata666
Copy link
Member

martadinata666 commented May 12, 2023

Notes:
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#wildcard-requirements (crates.io not supporting wildcard)

Copied from rust doc Note: [crates.io](https://crates.io/) does not allow bare * versions.

nitnelave and others added 2 commits May 12, 2023 15:37
Change publish job with matrix, don't fail if another job fail.
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #578 (1b2dfbe) into main (d720a78) will decrease coverage by 1.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   84.01%   82.90%   -1.12%     
==========================================
  Files          39       39              
  Lines        6932     6932              
==========================================
- Hits         5824     5747      -77     
- Misses       1108     1185      +77     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants