Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for checking the password against HIBP for leaks #526

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nitnelave
Copy link
Member

See #39.

@nitnelave
Copy link
Member Author

We can do two things:

  • either merge this PR (roughly) as-is, after some technical reviews but not iterating on the frontend, then you create a PR to improve the frontend
  • or you create a PR that targets this branch with the frontend changes, so we merge a clean frontend directly.

WDYT?

Btw, to test this you'll need a HIBP API key.

@nitnelave nitnelave changed the title [WIP] Add support for checking the password against HIPB for leaks [WIP] Add support for checking the password against HIBP for leaks Apr 4, 2023
@pixelrazor
Copy link
Collaborator

We can do two things:

  • either merge this PR (roughly) as-is, after some technical reviews but not iterating on the frontend, then you create a PR to improve the frontend
  • or you create a PR that targets this branch with the frontend changes, so we merge a clean frontend directly.

WDYT?

Btw, to test this you'll need a HIBP API key.

Let me get some time to play with it in the current state and i'll get back with an opnion on that

@nitnelave nitnelave marked this pull request as draft April 11, 2023 21:05
server/src/infra/auth_service.rs Outdated Show resolved Hide resolved
server/src/infra/auth_service.rs Outdated Show resolved Hide resolved
server/src/infra/cli.rs Outdated Show resolved Hide resolved
server/src/infra/configuration.rs Outdated Show resolved Hide resolved
server/src/infra/tcp_server.rs Outdated Show resolved Hide resolved
server/src/infra/tcp_server.rs Outdated Show resolved Hide resolved
server/src/infra/tcp_server.rs Outdated Show resolved Hide resolved
server/src/infra/tcp_server.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #526 (278fb16) into main (86b2b51) will decrease coverage by 1.28%.
The diff coverage is 0.00%.

❗ Current head 278fb16 differs from pull request most recent head 8c052c0. Consider uploading reports for the commit 8c052c0 to get more accurate results

@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
- Coverage   71.01%   69.73%   -1.28%     
==========================================
  Files          40       40              
  Lines        6799     6923     +124     
==========================================
  Hits         4828     4828              
- Misses       1971     2095     +124     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants