Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

James Austin - Map Demo #46

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

James Austin - Map Demo #46

wants to merge 6 commits into from

Conversation

jaustin3
Copy link

Updates Made

  • Added Bootstrap to improve the look of the UI. Moved the instructions and other information to popovers on buttons on the NavBar to save screen real estate
  • Removed ListBox and replaced with List Group Bootstrap control for better airport selection. The user can select\deselect an airport code to add\remove a marker on the map. Also added the City\State to display in the list so it makes more sense for the user, in addition to allowing the city\state to be searched on.
  • Added search function to the list which will update the list with the filter the user has typed.
  • Added InfoWindows on Markers that display the airport information along with a link to clear the marker.
  • Added "Select All" and "Clear All" functionality to clear\add all airport markers.
  • I also altered the logic to center the map on the most recent airport that was marked.
  • Moved javascript and css files to assets folder to condense project structure.

Interesting Things

  • I have never worked with the Google Maps API before, so it was cool to work with something that I use so frequently, and it was surprisingly easier to use than I expected.
  • JavaScript and JQuery are not my strongest skills so it was really fun to get to work with these while learning and watch things come together.

Suggestions for Improvement

  • A few things I would still like to improve would be to enhance the search functionality. It works, but there are a few improvements I would make, such as keeping the search box position fixed when the list is being scrolled through, and add the ability to search by a specific data point such City, State, or Airport Name
  • I left the table of airport information, as it sounded like one of the requirements was to fill in the table, but I believe this could be removed\updated in the future since the same information is displayed in the InfoWindows.
  • Alter navbar and grids to be collapsible for use on multiple different displays

Above and Beyond

  • I think that adding the InfoWindows to the Markers was a nice addition to the site. I kept the same formatting as the original table on the window so it had the same feel, but it makes the markers more useful.

Checking in demo in current state.
Add Search List Item
Clear Search box when Clear All is clicked
Add City\State to list group
Allow user to reset the search by clicking link underneath box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant