Project Submit #44
Open
Project Submit #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made several updates:
Added text search functionality with jQuery autocomplete
Added custom pins with css formatted info windows
Added ability to delete a marker with a right click
Moved layout around for a better user experience
Since I am new to Javascript there a few interesting things I noticed. The first of which was learning how to work with the google maps API. This was actually very user friendly and their documentation is extremely good. The other would be how the data flows from Js to HTML, I am used to using a getElementbyID, so it is always interesting to see different ways of accomplishing the same thing.
My suggestion for improvement would be add a collection of current pins boxes the user can click on and have the map snap to that location when clicked. I feel that would help improve the quality and usefulness of this app.
I feel like I went above and beyond with formatting the info windows. This really helps make the information easier to read and helps with the overall design flow.