Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] add conditions ordering tests/fixture #5

Merged
merged 1 commit into from Oct 18, 2020
Merged

[Tests] add conditions ordering tests/fixture #5

merged 1 commit into from Oct 18, 2020

Conversation

ljharb
Copy link
Owner

@ljharb ljharb commented Oct 9, 2020

Add tests that cover the ordering of conditions in every node version.

TODO: add import() tests for testing the import versions. Not sure how to do this since there's no ESM resolver in node.

(This PR brought to my attention the need for yargs/yargs#1776)

@ljharb ljharb added the hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it. label Oct 9, 2020
@ljharb ljharb force-pushed the conditions branch 18 times, most recently from faf7001 to 8bfb2f2 Compare October 16, 2020 19:48
@ljharb ljharb marked this pull request as ready for review October 18, 2020 02:29
@ljharb ljharb merged commit 8bfb2f2 into main Oct 18, 2020
@ljharb ljharb deleted the conditions branch October 18, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant