Add test to check that acls are being honored #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladAdGad
force-pushed
the
add-test-acl-honored
branch
from
8e2c299
to
e4c442d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test that checks if acl’s are being honored. Your existing test "test_acl_behaviour" doesn't seem to check it in the right way.
It is associated with commit e391f55
It's very strange that this has not been created by LFS team already, as I believe it’s important to see in the future if it is broken and you didn't provide any documentation about your fix. It depends on what version of fuse you use/have and this is turn affects the OS that the user uses.
You continue with 3.13 that is unstable but don't provide tests for your fixes and documentation. When looking at your jenkins (http://jenkins.lizardfs.org/) it frightens me.